Is it worth staying at All Star Movies to be on the disney property? Or is it better to try and be near downtown disney? Or is it better to be at the 'maingate' ?
Will you have a car?
(No? Stop here. Stay onsite.)
How much waking time do you plan to spend at your hotel?
(very little? Chalk one up for the cheapest room.)
Do you like the theme at All Star Movies?
(yes? One for All Stars.)
Do you make use of the hot tub at your hotel?
(yes? Choose a hotel with a hot tub - none at All Stars.)
Do you like to swim/rest midday at your hotel?
(yes? Choose any that are very nearby or onsite.)
Do you expect to spend evenings at PI & will both plan to drink alcohol?
(yes? Choose All Stars or DD hotels and take the bus.)
Do you plan to include non-Disney attractions in your vacation plans?
(yes? stay offsite - no need to pay Disney rates then drive to I-Dr. anyway.
If most of your answers point to All Stars, go for it. If most lean toward offsite, and if money is really tight and the extra $20 - $60 per day would make a real difference for you, then I'd choose offsite. For a couple who don't care as much about the buses and who don't have children to mingle with the mobs of kids at the All Stars and who spend a lot of time at the parks and who need to watch each dollar, I'd give offsite a try. We've had wonderful trips both offsite and onsite.
If you need to find a good offsite place, make sure you read the Orlando Hotels and Attractions board. Learn which less expensive hotels/motels are nice and which are poor. There's a huge difference between them, for the same prices. Also, with a tight budget, look for one that includes a hot breakfast.
Either way, choose well & enjoy your WDW vacation!